From 0f830b4219ac6ef55087331b8e14ef33e16201fe Mon Sep 17 00:00:00 2001 From: Jian Qiu Date: Fri, 4 Sep 2026 19:39:30 +0800 Subject: [PATCH] fix: verify test revisit (#25562) Co-authored-by: Qiu Jian --- pkg/notify/models/verify_test.go | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/pkg/notify/models/verify_test.go b/pkg/notify/models/verify_test.go index bfd8406d89..9b1d14b629 100644 --- a/pkg/notify/models/verify_test.go +++ b/pkg/notify/models/verify_test.go @@ -19,8 +19,9 @@ import ( ) func TestGenerateVerifyToken(t *testing.T) { + const draws = 200 seen := map[string]bool{} - for i := 0; i < 200; i++ { + for i := 0; i < draws; i++ { token, err := VerificationManager.generateVerifyToken() if err != nil { t.Fatalf("generateVerifyToken: %v", err) @@ -33,9 +34,12 @@ func TestGenerateVerifyToken(t *testing.T) { t.Fatalf("token %q contains non-digit", token) } } - if seen[token] { - t.Fatalf("duplicate token %q generated within 200 draws", token) - } seen[token] = true } + // 6-digit codes have only 1e6 values; uniqueness of 200 draws is not + // guaranteed (birthday paradox ~2%). The RNG must still not collapse + // to a constant sequence. + if len(seen) < 2 { + t.Fatalf("generateVerifyToken produced only %d distinct value(s) in %d draws", len(seen), draws) + } }