mirror of
https://hubproxy.babadafafafafa.cn/https://github.com/kube-vip/kube-vip.git
synced 2026-09-20 08:03:47 +08:00
be536eaaf7
* fix(kubevip): reject out-of-range routing protocol values Netlink carries the address and route protocol in a single byte, so a configured value above 255 was silently truncated on the wire and never matched again on readback. Reject it during config validation instead. Signed-off-by: Marcel Fest <marcel.fest@telekom.de> * feat(wireguard): qualify service tunnel IDs by protocol Sanitisation maps '-' onto the '_' separator, so "a-b/c" and "a/b-c" shared one nftables chain, and TCP and UDP on the same port collided. ServicePortIDs appends the protocol and, when sanitisation changed the name or the ID grew too long, a hash of the raw name. It also returns the previous port-only ID so existing chains can be migrated. Signed-off-by: Marcel Fest <marcel.fest@telekom.de> * fix(arp): guard manager state behind a single mutex Instances were kept in a sync.Map with a per-instance mutex for the refcount, so lookup and refcount update were not atomic: concurrent Insert and Remove could resurrect a deleted instance or drop a live one. Hold one manager mutex across both, and buffer link subscriptions so a netlink sender is never parked on an unread channel during shutdown. Signed-off-by: Marcel Fest <marcel.fest@telekom.de> * fix(instance): roll back partially created instances Instance creation added addresses, VLAN or macvlan links and DHCP clients incrementally, so a failure part way through left the node holding state nobody owned. Initialization now unwinds what it created, and link cleanup only deletes attachments this instance created that no remaining instance still uses. Namespace-dependent tests now skip unless KUBE_VIP_REQUIRE_NETNS is set, which CI sets on the privileged job so lost capabilities turn it red instead of silently skipping. Signed-off-by: Marcel Fest <marcel.fest@telekom.de> * test(e2e): give docker kill more time under parallel load The ARP suite runs four kind clusters against one Docker daemon, so acknowledging a leader kill regularly exceeded the 5s budget and failed the IPv6 failover specs before any assertion ran. Signed-off-by: Marcel Fest <marcel.fest@telekom.de> * fix: regression on preserveOnLeadershipLoss Signed-off-by: Marcel Fest <marcel.fest@telekom.de> * fix: use the introduced wireguard service_id Signed-off-by: Marcel Fest <marcel.fest@telekom.de> * fix(services): reuse link attachment ownership on service delete deleteService removed VLAN and macvlan links unconditionally, which tore down interfaces kube-vip had only adopted and interfaces another Service still used. Route the delete path through CleanupLinkAttachments and pass the remaining instances so ownership is handed over instead. Signed-off-by: Marcel Fest <marcel.fest@telekom.de> --------- Signed-off-by: Marcel Fest <marcel.fest@telekom.de>
66 lines
2.0 KiB
Go
66 lines
2.0 KiB
Go
package instance
|
|
|
|
import (
|
|
"sync"
|
|
"testing"
|
|
|
|
"github.com/kube-vip/kube-vip/pkg/kubevip"
|
|
v1 "k8s.io/api/core/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
)
|
|
|
|
func TestUIDUsesImmutableServiceUID(t *testing.T) {
|
|
serviceUID := types.UID("original-service")
|
|
instance := &Instance{
|
|
ServiceUID: serviceUID,
|
|
ServiceSnapshot: &v1.Service{ObjectMeta: metav1.ObjectMeta{
|
|
UID: types.UID("replacement-service"),
|
|
}},
|
|
}
|
|
|
|
if got := instance.UID(); got != serviceUID {
|
|
t.Fatalf("UID() = %q, want %q", got, serviceUID)
|
|
}
|
|
|
|
instance.ServiceUID = ""
|
|
if got := instance.UID(); got != "" {
|
|
t.Fatalf("UID() without ServiceUID = %q, want empty UID", got)
|
|
}
|
|
}
|
|
|
|
func TestCleanupStateIsImmutable(t *testing.T) {
|
|
original := &v1.Service{ObjectMeta: metav1.ObjectMeta{
|
|
Name: "service", Namespace: "default", Annotations: map[string]string{kubevip.ServiceLease: "shared"},
|
|
}, Spec: v1.ServiceSpec{LoadBalancerIP: "192.0.2.10", ExternalTrafficPolicy: v1.ServiceExternalTrafficPolicyTypeCluster}}
|
|
immutableInfo := serviceCleanupInfo(original)
|
|
instance := &Instance{
|
|
ServiceSnapshot: original,
|
|
ServiceAddresses: []string{"192.0.2.10"},
|
|
cleanupInfo: &immutableInfo,
|
|
}
|
|
instance.ServiceSnapshot = &v1.Service{ObjectMeta: metav1.ObjectMeta{Name: "changed"}}
|
|
|
|
cleanupInfo, ok := instance.CleanupInfo()
|
|
if !ok || cleanupInfo.Namespace != "default" || cleanupInfo.Name != "service" || cleanupInfo.Lease != "shared" ||
|
|
cleanupInfo.ExternalTrafficPolicy != v1.ServiceExternalTrafficPolicyTypeCluster {
|
|
t.Fatalf("CleanupInfo() = %+v, %t, want creation-time Service policy", cleanupInfo, ok)
|
|
}
|
|
}
|
|
|
|
func TestTransferLinkAttachmentOwnershipConcurrent(t *testing.T) {
|
|
target := &Instance{IsVLAN: true, VLANInterface: "eth0.42"}
|
|
var wg sync.WaitGroup
|
|
for range 100 {
|
|
wg.Go(func() {
|
|
if !transferLinkAttachmentOwnership("eth0.42", []*Instance{target}, true) {
|
|
t.Error("transferLinkAttachmentOwnership() did not find target")
|
|
}
|
|
})
|
|
}
|
|
wg.Wait()
|
|
if !target.vlanOwned.Load() {
|
|
t.Fatal("target did not receive VLAN ownership")
|
|
}
|
|
}
|