fanhuadesenlinnn/tdesktop
1
0
Fork 0
mirror of https://hubproxy.babadafafafafa.cn/https://github.com/telegramdesktop/tdesktop synced 2026-09-21 00:23:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed use-after-free in the filtered chats ripple.

Browse Source
This commit is contained in:
John Preston
2026-08-26 17:52:00 +04:00
parent 099b081f64
commit 4a9c4e5b85
1 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
Telegram/SourceFiles/dialogs/dialogs_inner_widget.cpp
View File

@@ -2490,7 +2490,25 @@ void InnerWidget::mousePressEvent(QMouseEvent *e) {
const auto filterId = _filterId;
const auto origin = e->pos()
- QPoint(0, filteredOffset() + result.top);
const auto updateCallback = [=] { repaintDialogRow(filterId, row); };
// The ripple may be parked in _rightButtons, which is owned by us
// and outlives the Row: _filterResultsGlobal is cleared on every
// query change. So never capture the Row pointer here.
const auto weakThis = base::make_weak(this);
const auto weakEntry = base::make_weak(row->entry());
const auto updateCallback = [weakThis, weakEntry, filterId] {
const auto that = weakThis.get();
const auto entry = weakEntry.get();
if (!that || !entry) {
return;
}
const auto i = ranges::find(
that->_filterResults,
Key(entry),
&FilterResult::key);
if (i != that->_filterResults.end()) {
that->repaintDialogRow(filterId, i->row);
}
};
if (addRightButtonRipple(origin, updateCallback)) {
} else if (_pressedTopicJump) {
row->addTopicJumpRipple(